Skip to content

test(language_scanner): use scan_file() & add tests for python packages #1758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 11, 2022

Conversation

yashugarg
Copy link
Contributor

fixes #1754

@yashugarg yashugarg changed the title test(language_scanner): use scan_file() and add tests for python packages test(language_scanner): use scan_file() & add tests for python packages Jul 7, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1758 (e994f0f) into main (6c13a9d) will increase coverage by 0.11%.
The diff coverage is 84.00%.

@@            Coverage Diff             @@
##             main    #1758      +/-   ##
==========================================
+ Coverage   83.84%   83.96%   +0.11%     
==========================================
  Files         307      307              
  Lines        6581     6599      +18     
  Branches     1068     1071       +3     
==========================================
+ Hits         5518     5541      +23     
+ Misses        820      815       -5     
  Partials      243      243              
Flag Coverage Δ
longtests 83.96% <84.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test/test_language_scanner.py 88.52% <84.00%> (-2.18%) ⬇️
cve_bin_tool/nvd_api.py 75.20% <0.00%> (-8.80%) ⬇️
cve_bin_tool/cvedb.py 83.33% <0.00%> (ø)
cve_bin_tool/cli.py 71.09% <0.00%> (+0.39%) ⬆️
cve_bin_tool/version_scanner.py 83.33% <0.00%> (+6.97%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@BreadGenie BreadGenie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! (And thank you @BreadGenie for reviewing!)

@terriko terriko merged commit e0eade3 into intel:main Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test: Use scan_file for language scanner
4 participants